Bug 134051

Summary: [Cocoa] Modernize one-method authentication
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Add -_webView:didReceiveAuthenticationChallenge:completionHandler: andersca: review+

mitz
Reported 2014-06-18 17:13:53 PDT
[Cocoa] Modernize one-method authentication
Attachments
Add -_webView:didReceiveAuthenticationChallenge:completionHandler: (9.86 KB, patch)
2014-06-18 17:19 PDT, mitz 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2014-06-18 17:19:54 PDT
Created attachment 233342 [details] Add -_webView:didReceiveAuthenticationChallenge:completionHandler:
WebKit Commit Bot
Comment 2 2014-06-18 17:22:24 PDT
Attachment 233342 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:616: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2014-06-18 17:24:23 PDT
Comment on attachment 233342 [details] Add -_webView:didReceiveAuthenticationChallenge:completionHandler: View in context: https://bugs.webkit.org/attachment.cgi?id=233342&action=review > Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:640 > + [NSException raise:NSInvalidArgumentException format:@"Invalid NSURLSessionAuthChallengeDisposition (%ld)", (long)disposition]; I think you should call checker->didCallCompletionHandler() before raising the exception here, otherwise you'll get another exception when the completionHandler is released.
mitz
Comment 4 2014-06-18 17:31:33 PDT
Committed <http://trac.webkit.org/r170137>.
Note You need to log in before you can comment on or make changes to this bug.