| Summary: | [Cocoa] Modernize one-method authentication | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | mitz | ||||
| Component: | WebKit2 | Assignee: | mitz | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
mitz
2014-06-18 17:13:53 PDT
Created attachment 233342 [details]
Add -_webView:didReceiveAuthenticationChallenge:completionHandler:
Attachment 233342 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:616: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 233342 [details] Add -_webView:didReceiveAuthenticationChallenge:completionHandler: View in context: https://bugs.webkit.org/attachment.cgi?id=233342&action=review > Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:640 > + [NSException raise:NSInvalidArgumentException format:@"Invalid NSURLSessionAuthChallengeDisposition (%ld)", (long)disposition]; I think you should call checker->didCallCompletionHandler() before raising the exception here, otherwise you'll get another exception when the completionHandler is released. Committed <http://trac.webkit.org/r170137>. |