Bug 134022

Summary: [Soup] Image Data URIs not displaying if media-type is not specified
Product: WebKit Reporter: Shanmuga Pandi M <shanmuga.m>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WORKSFORME    
Severity: Normal CC: berto, cdumez, cgarcia, commit-queue, danw, gustavo, gyuyoung.kim, mcatanzaro, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
Sample test file
none
Patch
none
Patch none

Shanmuga Pandi M
Reported 2014-06-18 02:00:31 PDT
Created attachment 233299 [details] Sample test file On Webkit2 EFL port, Steps to Reproduce: 1. Open attached sample html file. 2. Observe Actual Result: Nothing is displayed. Expected Result: One directory icon should get displayed Firefox and chrome working as expected. If Data-URI doesn't contain media-type, then ImageDecoder creation fails due to improper data it receives.
Attachments
Sample test file (342 bytes, text/html)
2014-06-18 02:00 PDT, Shanmuga Pandi M 		no flags
Details
Patch (3.44 KB, patch)
2014-06-18 02:59 PDT, Shanmuga Pandi M 		no flags
DetailsFormatted DiffDiff
Patch (3.54 KB, patch)
2014-06-18 03:17 PDT, Shanmuga Pandi M 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shanmuga Pandi M
Comment 1 2014-06-18 02:59:52 PDT
Created attachment 233301 [details] Patch
WebKit Commit Bot
Comment 2 2014-06-18 03:00:58 PDT
Attachment 233301 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Shanmuga Pandi M
Comment 3 2014-06-18 03:17:22 PDT
Created attachment 233303 [details] Patch
Dan Winship
Comment 4 2014-06-18 06:24:04 PDT
This seems like something that should be fixed in libsoup
Shanmuga Pandi M
Comment 5 2014-06-18 06:28:45 PDT
(In reply to comment #4) > This seems like something that should be fixed in libsoup Yes. Can we push this patch until libsoup fixes this issue?
Gustavo Noronha (kov)
Comment 6 2014-06-19 13:02:08 PDT
Perhaps you could patch libsoup instead? Shouldn't be much harder than fixing it here.
Michael Catanzaro
Comment 7 2016-09-17 07:14:11 PDT
Comment on attachment 233303 [details] Patch Hi, Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting. To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug.
Michael Catanzaro
Comment 8 2016-09-17 07:14:37 PDT
I see a directory icon, so I guess it's already been fixed.
Note You need to log in before you can comment on or make changes to this bug.