Bug 133989

Summary:

Only show telephone number highlights if only one number is selected

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebKit2

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

thorton

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

All

Attachments:

Description	Flags
Patch v1	thorton: review+

Description Brady Eidson 2014-06-17 11:51:10 PDT

Only show telephone number highlights if only one number is selected

<rdar://problem/16874568>

Comment 1 Brady Eidson 2014-06-17 11:52:06 PDT

Also only while the mouse is over the phone number.

Comment 2 Brady Eidson 2014-06-17 12:03:30 PDT

Created attachment 233246 [details]
Patch v1

Comment 3 Tim Horton 2014-06-17 12:07:21 PDT

Comment on attachment 233246 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=233246&action=review

> Source/WebKit2/WebProcess/WebPage/TelephoneNumberOverlayController.h:54
>      DDHighlightRef highlight() const { return m_highlight.get(); }

Weird that this isn't in a mac/ subdirectory.

> Source/WebKit2/WebProcess/WebPage/TelephoneNumberOverlayController.h:56
> +    bool hovered() const { return m_hovered; }

isHovered.

Comment 4 Brady Eidson 2014-06-17 12:18:30 PDT

http://trac.webkit.org/changeset/170067