Bug 133920

Summary: Copy SharedBuffer data into IPC message directly
Product: WebKit Reporter: Pratik Solanki <psolanki>
Component: WebKit2Assignee: Pratik Solanki <psolanki>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, andersca, ap, buildbot, kling, psolanki, rniwa, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 none

Pratik Solanki
Reported 2014-06-14 15:51:16 PDT
When Data array callbacks are enabled, we currently merge all the CFDataRefs in SharedBuffer into one contiguous memory buffer before copying into the IPC message. We can avoid the merge into a single buffer here.
Attachments
Patch (6.90 KB, patch)
2014-06-14 15:57 PDT, Pratik Solanki 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (521.85 KB, application/zip)
2014-06-14 19:11 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Pratik Solanki
Comment 1 2014-06-14 15:57:59 PDT
Created attachment 233130 [details] Patch
Sam Weinig
Comment 2 2014-06-14 16:46:12 PDT
I don't think there is any reason to add a SharedBufferDataReference type. Instead, we should just add a coder for SharedBuffer.
Build Bot
Comment 3 2014-06-14 19:11:00 PDT
Comment on attachment 233130 [details] Patch Attachment 233130 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4560879307718656 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html
Build Bot
Comment 4 2014-06-14 19:11:03 PDT
Created attachment 233133 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Pratik Solanki
Comment 5 2014-06-16 11:30:31 PDT
(In reply to comment #3) > (From update of attachment 233130 [details]) > Attachment 233130 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://webkit-queues.appspot.com/results/4560879307718656 > > New failing tests: > media/W3C/video/networkState/networkState_during_loadstart.html Looks like a flaky test. I see these failures in other bugs as well so this is not related to my change.
Pratik Solanki
Comment 6 2014-06-19 11:33:44 PDT
Comment on attachment 233130 [details] Patch Clearing flags on attachment: 233130 Committed r170154: <http://trac.webkit.org/changeset/170154>
Pratik Solanki
Comment 7 2014-06-19 11:33:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.