Bug 13390

Summary: [js-collector-tweaks] collect less often, now that blocks are bigger and cells are smaller
Product: WebKit Reporter: Maciej Stachowiak <mjs>
Component: JavaScriptCoreAssignee: Maciej Stachowiak <mjs>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on: 13389    
Bug Blocks:    
Attachments:
Description Flags
10-js-gc-collect-less.patch.txt darin: review+

Maciej Stachowiak
Reported 2007-04-18 01:03:09 PDT
Raise ALLOCATIONS_PER_COLLECTION to 4000, for 3.7% iBench speed improvement. Now that the cell size is smaller and the block size is bigger, we can fit 4000 objects in the two spare cells the collector is willing to keep around, so collect a bit less often.
Attachments
10-js-gc-collect-less.patch.txt (1.35 KB, patch)
2007-04-18 01:03 PDT, Maciej Stachowiak 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1 2007-04-18 01:03:43 PDT
Created attachment 14071 [details] 10-js-gc-collect-less.patch.txt
Darin Adler
Comment 2 2007-04-18 11:31:09 PDT
Comment on attachment 14071 [details] 10-js-gc-collect-less.patch.txt r=me, once all the preconditions are met
Mark Rowe (bdash)
Comment 3 2007-04-27 01:07:32 PDT
This was landed in r21048.
Note You need to log in before you can comment on or make changes to this bug.