Bug 133888

Summary: Clean up layers in RemoteLayerTreeHost::clearLayers()
Product: WebKit Reporter: Martin Hock <mhock>
Component: WebKit2Assignee: Martin Hock <mhock>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, rniwa, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
thorton: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 none

Martin Hock
Reported 2014-06-13 16:03:28 PDT
Layers needed to be removed from their parent.
Attachments
patch (1.50 KB, patch)
2014-06-13 16:04 PDT, Martin Hock 		thorton: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (505.54 KB, application/zip)
2014-06-13 17:03 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Martin Hock
Comment 1 2014-06-13 16:04:58 PDT
Created attachment 233085 [details] patch
Tim Horton
Comment 2 2014-06-13 16:25:53 PDT
Comment on attachment 233085 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=233085&action=review > Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm:35 > +#if PLATFORM(IOS) > +#import <UIKit/UIView.h> > +#endif this belongs in its own block.
Build Bot
Comment 3 2014-06-13 17:03:45 PDT
Comment on attachment 233085 [details] patch Attachment 233085 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5916438497853440 New failing tests: http/tests/appcache/404-manifest.html
Build Bot
Comment 4 2014-06-13 17:03:47 PDT
Created attachment 233093 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Martin Hock
Comment 5 2014-06-13 17:04:39 PDT
Committed r169957: <http://trac.webkit.org/changeset/169957>
Martin Hock
Comment 6 2014-06-16 10:21:42 PDT
The ML bot here seems to have passed with this commit included: http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK2%20%28Tests%29/builds/19056
Note You need to log in before you can comment on or make changes to this bug.