Bug 133887

Summary: Move utility functions from WebLayer to PlatformCALayer
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Layout and RenderingAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, ossy, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
simon.fraser: review+
fix the build
commit-queue: commit-queue-
fix the build none

Description Brent Fulgham 2014-06-13 16:00:24 PDT 
WebLayer has a set of bare utility functions used by parts of the Tiled Drawing implementation. This refactoring moves them from WebLayer (which is only used in Cocoa builds) to PlatformCALayer, where they can be used by all CoreAnimation-backed clients.
Comment 1 Radar WebKit Bug Importer 2014-06-13 16:01:40 PDT 
<rdar://problem/17309622>
Comment 2 Brent Fulgham 2014-06-13 16:30:58 PDT 
Created attachment 233089 [details]
Patch
Comment 3 Tim Horton 2014-06-13 16:42:32 PDT 
Maybe you want to fix the FIXME at the top of RemoteLayerBackingStore which you made it very easy to do with this patch?
Comment 4 Brent Fulgham 2014-06-13 19:59:54 PDT 
(In reply to comment #3)
> Maybe you want to fix the FIXME at the top of RemoteLayerBackingStore which you made it very easy to do with this patch?

Done!
Comment 5 Brent Fulgham 2014-06-13 20:00:44 PDT 
Committed revision 169960 <http://trac.webkit.org/changeset/169960>.
Comment 6 Brent Fulgham 2014-06-13 20:01:09 PDT 
Confirmed builds on OS X and iOS.
Comment 7 Tim Horton 2014-06-13 21:17:42 PDT 
(In reply to comment #6)
> Confirmed builds on OS X and iOS.

I'm getting lots of build failures on OS X...
Comment 8 Tim Horton 2014-06-13 21:28:25 PDT 
Reopened for build fix.
Comment 9 Tim Horton 2014-06-13 21:28:46 PDT 
Created attachment 233101 [details]
fix the build
Comment 10 WebKit Commit Bot 2014-06-13 21:29:42 PDT 
Comment on attachment 233101 [details]
fix the build

Rejecting attachment 233101 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 233101, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/5686256168075264
Comment 11 Tim Horton 2014-06-13 21:31:17 PDT 
Created attachment 233102 [details]
fix the build
Comment 12 WebKit Commit Bot 2014-06-13 22:10:07 PDT 
Comment on attachment 233102 [details]
fix the build

Clearing flags on attachment: 233102

Committed r169961: <http://trac.webkit.org/changeset/169961>
Comment 13 Csaba Osztrogonác 2014-06-14 02:25:57 PDT 
It broke the Apple Windows build too, as the EWS noticed before landing:
     1>..\platform\graphics\ca\PlatformCALayer.cpp(56): error C3861: 'snprintf': identifier not found
Comment 14 Brent Fulgham 2014-06-14 08:44:35 PDT 
(In reply to comment #7)
> (In reply to comment #6)
> > Confirmed builds on OS X and iOS.
> 
> I'm getting lots of build failures on OS X...

Oh no! My commit was from WebCore and I didn't land my WebKit2 changes. Doh!
Comment 15 Brent Fulgham 2014-06-14 08:45:49 PDT 
(In reply to comment #13)
> It broke the Apple Windows build too, as the EWS noticed before landing:
>      1>..\platform\graphics\ca\PlatformCALayer.cpp(56): error C3861: 'snprintf': identifier not found

I just saw this, too. It needs <wtf/StringExtras.h> for the Windows port.

Committed r169961: <http://trac.webkit.org/changeset/169968>.
Comment 16 Tim Horton 2014-06-17 23:51:15 PDT 
(In reply to comment #4)
> (In reply to comment #3)
> > Maybe you want to fix the FIXME at the top of RemoteLayerBackingStore which you made it very easy to do with this patch?
> 
> Done!

It doesn't look done! (maybe because you didn't land the WK2 part?)