Bug 133887

Summary:

Move utility functions from WebLayer to PlatformCALayer

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

Layout and Rendering

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, ossy, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	simon.fraser: review+
fix the build	commit-queue: commit-queue-
fix the build	none

Brent Fulgham

Reported 2014-06-13 16:00:24 PDT

WebLayer has a set of bare utility functions used by parts of the Tiled Drawing implementation. This refactoring moves them from WebLayer (which is only used in Cocoa builds) to PlatformCALayer, where they can be used by all CoreAnimation-backed clients.

Attachments
Patch (22.08 KB, patch) 2014-06-13 16:30 PDT, Brent Fulgham	simon.fraser: review+	Details Formatted Diff Diff
fix the build (2.32 KB, patch) 2014-06-13 21:28 PDT, Tim Horton	commit-queue: commit-queue-	Details Formatted Diff Diff
fix the build (2.33 KB, patch) 2014-06-13 21:31 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2014-06-13 16:01:40 PDT

<rdar://problem/17309622>

Brent Fulgham

Comment 2 2014-06-13 16:30:58 PDT

Created attachment 233089 [details] Patch

Tim Horton

Comment 3 2014-06-13 16:42:32 PDT

Maybe you want to fix the FIXME at the top of RemoteLayerBackingStore which you made it very easy to do with this patch?

Brent Fulgham

Comment 4 2014-06-13 19:59:54 PDT

(In reply to comment #3) > Maybe you want to fix the FIXME at the top of RemoteLayerBackingStore which you made it very easy to do with this patch? Done!

Brent Fulgham

Comment 5 2014-06-13 20:00:44 PDT

Committed revision 169960 <http://trac.webkit.org/changeset/169960>.

Brent Fulgham

Comment 6 2014-06-13 20:01:09 PDT

Confirmed builds on OS X and iOS.

Tim Horton

Comment 7 2014-06-13 21:17:42 PDT

(In reply to comment #6) > Confirmed builds on OS X and iOS. I'm getting lots of build failures on OS X...

Tim Horton

Comment 8 2014-06-13 21:28:25 PDT

Reopened for build fix.

Tim Horton

Comment 9 2014-06-13 21:28:46 PDT

Created attachment 233101 [details] fix the build

WebKit Commit Bot

Comment 10 2014-06-13 21:29:42 PDT

Comment on attachment 233101 [details] fix the build Rejecting attachment 233101 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 233101, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/5686256168075264

Tim Horton

Comment 11 2014-06-13 21:31:17 PDT

Created attachment 233102 [details] fix the build

WebKit Commit Bot

Comment 12 2014-06-13 22:10:07 PDT

Comment on attachment 233102 [details] fix the build Clearing flags on attachment: 233102 Committed r169961: <http://trac.webkit.org/changeset/169961>

Csaba Osztrogonác

Comment 13 2014-06-14 02:25:57 PDT

It broke the Apple Windows build too, as the EWS noticed before landing: 1>..\platform\graphics\ca\PlatformCALayer.cpp(56): error C3861: 'snprintf': identifier not found

Brent Fulgham

Comment 14 2014-06-14 08:44:35 PDT

(In reply to comment #7) > (In reply to comment #6) > > Confirmed builds on OS X and iOS. > > I'm getting lots of build failures on OS X... Oh no! My commit was from WebCore and I didn't land my WebKit2 changes. Doh!

Brent Fulgham

Comment 15 2014-06-14 08:45:49 PDT

(In reply to comment #13) > It broke the Apple Windows build too, as the EWS noticed before landing: > 1>..\platform\graphics\ca\PlatformCALayer.cpp(56): error C3861: 'snprintf': identifier not found I just saw this, too. It needs <wtf/StringExtras.h> for the Windows port. Committed r169961: <http://trac.webkit.org/changeset/169968>.

Tim Horton

Comment 16 2014-06-17 23:51:15 PDT

(In reply to comment #4) > (In reply to comment #3) > > Maybe you want to fix the FIXME at the top of RemoteLayerBackingStore which you made it very easy to do with this patch? > > Done! It doesn't look done! (maybe because you didn't land the WK2 part?)

Note You need to log in before you can comment on or make changes to this bug.