WebLayer has a set of bare utility functions used by parts of the Tiled Drawing implementation. This refactoring moves them from WebLayer (which is only used in Cocoa builds) to PlatformCALayer, where they can be used by all CoreAnimation-backed clients.
<rdar://problem/17309622>
Created attachment 233089 [details] Patch
Maybe you want to fix the FIXME at the top of RemoteLayerBackingStore which you made it very easy to do with this patch?
(In reply to comment #3) > Maybe you want to fix the FIXME at the top of RemoteLayerBackingStore which you made it very easy to do with this patch? Done!
Committed revision 169960 <http://trac.webkit.org/changeset/169960>.
Confirmed builds on OS X and iOS.
(In reply to comment #6) > Confirmed builds on OS X and iOS. I'm getting lots of build failures on OS X...
Reopened for build fix.
Created attachment 233101 [details] fix the build
Comment on attachment 233101 [details] fix the build Rejecting attachment 233101 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 233101, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/5686256168075264
Created attachment 233102 [details] fix the build
Comment on attachment 233102 [details] fix the build Clearing flags on attachment: 233102 Committed r169961: <http://trac.webkit.org/changeset/169961>
It broke the Apple Windows build too, as the EWS noticed before landing: 1>..\platform\graphics\ca\PlatformCALayer.cpp(56): error C3861: 'snprintf': identifier not found
(In reply to comment #7) > (In reply to comment #6) > > Confirmed builds on OS X and iOS. > > I'm getting lots of build failures on OS X... Oh no! My commit was from WebCore and I didn't land my WebKit2 changes. Doh!
(In reply to comment #13) > It broke the Apple Windows build too, as the EWS noticed before landing: > 1>..\platform\graphics\ca\PlatformCALayer.cpp(56): error C3861: 'snprintf': identifier not found I just saw this, too. It needs <wtf/StringExtras.h> for the Windows port. Committed r169961: <http://trac.webkit.org/changeset/169968>.
(In reply to comment #4) > (In reply to comment #3) > > Maybe you want to fix the FIXME at the top of RemoteLayerBackingStore which you made it very easy to do with this patch? > > Done! It doesn't look done! (maybe because you didn't land the WK2 part?)