Bug 133841

Summary: [EFL][WK2] Change ewk_view_settings_get to ewk_page_group_settings_get
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, bunhere, cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, rniwa, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 none

Ryuan Choi
Reported 2014-06-13 00:29:59 PDT
Ewk_Settings object is a member of Ewk_Page_Group. So, Ewk_Page_Group is better place for the getter of Ewk_Settings.
Attachments
Patch (16.88 KB, patch)
2014-06-13 00:37 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (586.15 KB, application/zip)
2014-06-13 06:14 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2014-06-13 00:37:49 PDT
Created attachment 233030 [details] Patch
Build Bot
Comment 2 2014-06-13 06:14:12 PDT
Comment on attachment 233030 [details] Patch Attachment 233030 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5282096658513920 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html
Build Bot
Comment 3 2014-06-13 06:14:18 PDT
Created attachment 233045 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Gyuyoung Kim
Comment 4 2014-06-13 07:21:21 PDT
Comment on attachment 233030 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233030&action=review I don't have big opinion about this change. However, it looks there is no critical issue. > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_page_group.cpp:62 > + Nit: unnecessary line.
Ryuan Choi
Comment 5 2014-06-15 18:46:30 PDT
Committed r169997: <http://trac.webkit.org/changeset/169997>
Ryuan Choi
Comment 6 2014-06-15 18:51:58 PDT
Comment on attachment 233030 [details] Patch clearing r+. Minor, but it will be more informative to application developers. From now, application developers will know that they don't need to change the settings per webview.
Note You need to log in before you can comment on or make changes to this bug.