| Summary: | [EFL][WK2] Change ewk_view_settings_get to ewk_page_group_settings_get | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryuan Choi <ryuan.choi> | ||||||
| Component: | WebKit EFL | Assignee: | Ryuan Choi <ryuan.choi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | buildbot, bunhere, cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, rniwa, sergio | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Ryuan Choi
2014-06-13 00:29:59 PDT
Created attachment 233030 [details]
Patch
Comment on attachment 233030 [details] Patch Attachment 233030 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5282096658513920 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html Created attachment 233045 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 233030 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233030&action=review I don't have big opinion about this change. However, it looks there is no critical issue. > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_page_group.cpp:62 > + Nit: unnecessary line. Committed r169997: <http://trac.webkit.org/changeset/169997> Comment on attachment 233030 [details]
Patch
clearing r+.
Minor, but it will be more informative to application developers.
From now, application developers will know that they don't need to change the settings per webview.
|