Bug 133841 - [EFL][WK2] Change ewk_view_settings_get to ewk_page_group_settings_get
Summary: [EFL][WK2] Change ewk_view_settings_get to ewk_page_group_settings_get
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-13 00:29 PDT by Ryuan Choi
Modified: 2014-06-15 18:51 PDT (History)
8 users (show)

See Also:

Attachments
Patch (16.88 KB, patch)
2014-06-13 00:37 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (586.15 KB, application/zip)
2014-06-13 06:14 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2014-06-13 00:29:59 PDT 
Ewk_Settings object is a member of Ewk_Page_Group.
So, Ewk_Page_Group is better place for the getter of Ewk_Settings.
Comment 1 Ryuan Choi 2014-06-13 00:37:49 PDT 
Created attachment 233030 [details]
Patch
Comment 2 Build Bot 2014-06-13 06:14:12 PDT 
Comment on attachment 233030 [details]
Patch

Attachment 233030 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5282096658513920

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html
Comment 3 Build Bot 2014-06-13 06:14:18 PDT 
Created attachment 233045 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 4 Gyuyoung Kim 2014-06-13 07:21:21 PDT 
Comment on attachment 233030 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233030&action=review

I don't have big opinion about this change. However, it looks there is no critical issue.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_page_group.cpp:62
> +

Nit: unnecessary line.
Comment 5 Ryuan Choi 2014-06-15 18:46:30 PDT 
Committed r169997: <http://trac.webkit.org/changeset/169997>
Comment 6 Ryuan Choi 2014-06-15 18:51:58 PDT 
Comment on attachment 233030 [details]
Patch

clearing r+.

Minor, but it will be more informative to application developers.

From now, application developers will know that they don't need to change the settings per webview.