Bug 133821

Summary: [ftlopt] A DFG inlined ById access variant should not speak of a chain, but only of what structures to test the base for, whether to use a constant as an alternate base for the actual access, and what structures to check on what additional cell constants
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 133229    
Attachments:
Description Flags
work in progress
none
the patch mhahnenberg: review+

Description Filip Pizlo 2014-06-12 14:18:21 PDT 
This will allow better inlining of cases where there are multiple accesses that share different prototype chains but ultimately hit the same prototype in the end.
Comment 1 Filip Pizlo 2014-06-12 14:21:57 PDT 
Created attachment 232986 [details]
work in progress

Compiles and crashes on launch.  It's a good start!
Comment 2 Filip Pizlo 2014-06-12 16:33:42 PDT 
Created attachment 233006 [details]
the patch
Comment 3 Mark Hahnenberg 2014-06-13 14:21:33 PDT 
Comment on attachment 233006 [details]
the patch

r=me
Comment 4 Filip Pizlo 2014-06-13 14:49:51 PDT 
Landed in http://trac.webkit.org/changeset/169950