Bug 133821

Summary: [ftlopt] A DFG inlined ById access variant should not speak of a chain, but only of what structures to test the base for, whether to use a constant as an alternate base for the actual access, and what structures to check on what additional cell constants
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 133229    
Attachments:
Description Flags
work in progress
none
the patch mhahnenberg: review+

Filip Pizlo
Reported 2014-06-12 14:18:21 PDT
This will allow better inlining of cases where there are multiple accesses that share different prototype chains but ultimately hit the same prototype in the end.
Attachments
work in progress (47.09 KB, patch)
2014-06-12 14:21 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (57.09 KB, patch)
2014-06-12 16:33 PDT, Filip Pizlo 		mhahnenberg: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-06-12 14:21:57 PDT
Created attachment 232986 [details] work in progress Compiles and crashes on launch. It's a good start!
Filip Pizlo
Comment 2 2014-06-12 16:33:42 PDT
Created attachment 233006 [details] the patch
Mark Hahnenberg
Comment 3 2014-06-13 14:21:33 PDT
Comment on attachment 233006 [details] the patch r=me
Filip Pizlo
Comment 4 2014-06-13 14:49:51 PDT
Landed in http://trac.webkit.org/changeset/169950
Note You need to log in before you can comment on or make changes to this bug.