Bug 13382

Summary: [js-collector-tweaks] Remove JS oversize allocator
Product: WebKit Reporter: Maciej Stachowiak <mjs>
Component: JavaScriptCoreAssignee: Maciej Stachowiak <mjs>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on: 13381    
Bug Blocks: 13383, 13389    
Attachments:
Description Flags
02-js-gc-forbid-oversize.patch.txt darin: review+

Maciej Stachowiak
Reported 2007-04-18 00:03:39 PDT
With the Window object using the oversize allocator, it can be removed entirely. This depends on the patch in 13381
Attachments
02-js-gc-forbid-oversize.patch.txt (7.29 KB, patch)
2007-04-18 00:05 PDT, Maciej Stachowiak 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1 2007-04-18 00:05:38 PDT
Created attachment 14063 [details] 02-js-gc-forbid-oversize.patch.txt
Darin Adler
Comment 2 2007-04-18 11:02:23 PDT
Comment on attachment 14063 [details] 02-js-gc-forbid-oversize.patch.txt Looks fine. I would have suggested using a simpler approach for CellSize, using sizeof(void*) as the parmaeter rather than the two booleans, as in the IntTypes template in HashFunctions.h.
Geoffrey Garen
Comment 3 2007-04-18 21:11:19 PDT
Just wondering -- how did you verify that max object size? Can we make that verification happen at compile time?
Maciej Stachowiak
Comment 4 2007-04-22 21:02:30 PDT
I took Darin's preferred approach to the size selection. Re Geoff's comment, I could not figure out a good way to do the check at compile time.
Note You need to log in before you can comment on or make changes to this bug.