Bug 133775

Summary:

Keep CFDataRefs in SharedBuffer instead of merging them

Product:

WebKit

Reporter:

Pratik Solanki <psolanki>

Component:

New Bugs

Assignee:

Pratik Solanki <psolanki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, beidson, commit-queue, kling, psolanki

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Pratik Solanki 2014-06-11 16:06:34 PDT

Keep CFDataRefs in SharedBuffer instead of merging them

Comment 1 Pratik Solanki 2014-06-11 16:15:53 PDT

Created attachment 232919 [details]
Patch

Comment 2 Alexey Proskuryakov 2014-06-11 16:30:24 PDT

Comment on attachment 232919 [details]
Patch

There is a case for (count == 1) above the modified code, should it be updated in the same way too?

r=me assuming that there is a measurable improvement somewhere.

Comment 3 Alexey Proskuryakov 2014-06-11 16:31:07 PDT

> There is a case for (count == 1) above the modified code, should it be updated in the same way too?

No, I misread that code.

Comment 4 Pratik Solanki 2014-06-11 17:41:36 PDT

(In reply to comment #2)
> (From update of attachment 232919 [details])

> r=me assuming that there is a measurable improvement somewhere.

Thanks for the review. By itself this will not improve performance but next up I would like to pass the SharedBuffer all the way down to IPC message send so that we can avoid merging the CFData and directly write to the IPC message.

Comment 5 WebKit Commit Bot 2014-06-11 17:47:20 PDT

Comment on attachment 232919 [details]
Patch

Clearing flags on attachment: 232919

Committed r169868: <http://trac.webkit.org/changeset/169868>

Comment 6 WebKit Commit Bot 2014-06-11 17:47:23 PDT

All reviewed patches have been landed.  Closing bug.