Bug 133770 – WTR cleanup: push per-test viewport configuration into TestController, where platforms can customize it

• Component: New Bugs
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

WTR cleanup: push per-test viewport configuration into TestController, where platforms can customize it

[Simon Fraser (smfr)]

Created attachment 232910 [details]
Patch

[Anders Carlsson]

Comment on attachment 232910 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232910&action=review

> Tools/WebKitTestRunner/ios/TestControllerIOS.mm:72
> +    if (shouldMakeViewportFlexible(test.pathOrURL())) {

Early return?

> Tools/WebKitTestRunner/mac/TestControllerMac.mm:89
> +    WKRetainPtr<WKMutableDictionaryRef> viewOptions = adoptWK(WKMutableDictionaryCreate());
> +    WKRetainPtr<WKStringRef> useThreadedScrollingKey = adoptWK(WKStringCreateWithUTF8CString("ThreadedScrolling"));
> +    WKRetainPtr<WKBooleanRef> useThreadedScrollingValue = adoptWK(WKBooleanCreate(shouldUseThreadedScrolling(test.pathOrURL())));
> +    WKDictionarySetItem(viewOptions.get(), useThreadedScrollingKey.get(), useThreadedScrollingValue.get());
> +
> +    WKRetainPtr<WKStringRef> useRemoteLayerTreeKey = adoptWK(WKStringCreateWithUTF8CString("RemoteLayerTree"));
> +    WKRetainPtr<WKBooleanRef> useRemoteLayerTreeValue = adoptWK(WKBooleanCreate(shouldUseRemoteLayerTree()));

These can all be auto.

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/169845