Bug 133770

Summary:

WTR cleanup: push per-test viewport configuration into TestController, where platforms can customize it

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	andersca: review+

Description Simon Fraser (smfr) 2014-06-11 14:56:52 PDT

WTR cleanup: push per-test viewport configuration into TestController, where platforms can customize it

Comment 1 Simon Fraser (smfr) 2014-06-11 14:57:56 PDT

Created attachment 232910 [details]
Patch

Comment 2 Anders Carlsson 2014-06-11 14:59:39 PDT

Comment on attachment 232910 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232910&action=review

> Tools/WebKitTestRunner/ios/TestControllerIOS.mm:72
> +    if (shouldMakeViewportFlexible(test.pathOrURL())) {

Early return?

> Tools/WebKitTestRunner/mac/TestControllerMac.mm:89
> +    WKRetainPtr<WKMutableDictionaryRef> viewOptions = adoptWK(WKMutableDictionaryCreate());
> +    WKRetainPtr<WKStringRef> useThreadedScrollingKey = adoptWK(WKStringCreateWithUTF8CString("ThreadedScrolling"));
> +    WKRetainPtr<WKBooleanRef> useThreadedScrollingValue = adoptWK(WKBooleanCreate(shouldUseThreadedScrolling(test.pathOrURL())));
> +    WKDictionarySetItem(viewOptions.get(), useThreadedScrollingKey.get(), useThreadedScrollingValue.get());
> +
> +    WKRetainPtr<WKStringRef> useRemoteLayerTreeKey = adoptWK(WKStringCreateWithUTF8CString("RemoteLayerTree"));
> +    WKRetainPtr<WKBooleanRef> useRemoteLayerTreeValue = adoptWK(WKBooleanCreate(shouldUseRemoteLayerTree()));

These can all be auto.

Comment 3 Simon Fraser (smfr) 2014-06-11 15:09:51 PDT

http://trac.webkit.org/changeset/169845