Bug 133766

Summary:

Implement swipeWithEvent for non-fluid swipes

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

WebKit2

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, simon.fraser

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	andersca: review+

Description Tim Horton 2014-06-11 14:17:46 PDT

<rdar://problem/17126889>

Comment 1 Tim Horton 2014-06-11 14:21:37 PDT

Created attachment 232904 [details]
patch

Comment 2 Anders Carlsson 2014-06-11 14:24:32 PDT

Comment on attachment 232904 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232904&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.mm:1188
> +    if ([self shouldIgnoreMouseEvents])
> +        return;
> +
> +    if (!_data->_allowsBackForwardNavigationGestures)
> +        return;
> +
> +    if ([event deltaX] > 0.0)
> +        _data->_page->goBack();
> +    else if ([event deltaX] < 0.0)
> +        _data->_page->goForward();

Dot syntax.

Should we call super if we can't swipe?

Comment 3 Tim Horton 2014-06-11 15:47:59 PDT

http://trac.webkit.org/changeset/169850