Bug 133739

Summary: Some JSValue::get() micro-optimizations.
Product: WebKit Reporter: Andreas Kling <kling>
Component: JavaScriptCoreAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, kling, mhahnenberg, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Description Andreas Kling 2014-06-11 08:54:18 PDT
More hax to make GetByVal do less work.
Comment 1 Andreas Kling 2014-06-11 08:54:58 PDT
Created attachment 232868 [details]
Patch
Comment 2 Ryosuke Niwa 2014-06-11 09:32:00 PDT
Also see https://bugs.webkit.org/show_bug.cgi?id=133727
Comment 3 Geoffrey Garen 2014-06-11 11:29:44 PDT
Comment on attachment 232868 [details]
Patch

r=me
Comment 4 Andreas Kling 2014-06-11 11:40:47 PDT
Committed r169815: <http://trac.webkit.org/changeset/169815>
Comment 5 Ryosuke Niwa 2014-06-11 11:43:20 PDT
(In reply to comment #4)
> Committed r169815: <http://trac.webkit.org/changeset/169815>

Could you be able to tell us how much improvement you saw on https://bug-133727-attachments.webkit.org/attachment.cgi?id=232853 ?
Comment 6 Andreas Kling 2014-06-11 12:07:27 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > Committed r169815: <http://trac.webkit.org/changeset/169815>
> 
> Could you be able to tell us how much improvement you saw on https://bug-133727-attachments.webkit.org/attachment.cgi?id=232853 ?

Two samples:

55.15ms -> 46.78ms
54.52ms -> 46.64ms