Bug 13371

Summary:

DumpRenderTree --pixel-tests renders each test twice

Product:

WebKit

Reporter:

mitz

Component:

Tools / Tests

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

523.x (Safari 3)

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Paint only once (unless testing repaint)	darin: review+

mitz

Reported Tuesday, April 17, 2007 12:02:31 PM UTC

Since WebKit is now supposed to paint on load (currently disabled because of <rdar://problem/5092361> but simulated by DumpRenderTree), DumpRenderTree ends up rendering each test to the window in addition to rendering to the offscreen buffer.

Attachments
Paint only once (unless testing repaint) (4.35 KB, patch) 2007-11-13 16:20 PST, mitz	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 Wednesday, November 14, 2007 12:20:00 AM UTC

Created attachment 17244 [details] Paint only once (unless testing repaint) I verified that the painting code is run in --leaks mode simply by using Expose to bring in DRT's "offscreen" window and verifying that the tests are being rendered. I also verified that repaint tests work.

Darin Adler

Comment 2 Wednesday, November 14, 2007 12:47:13 AM UTC

Comment on attachment 17244 [details] Paint only once (unless testing repaint) r=me

mitz

Comment 3 Wednesday, November 14, 2007 12:50:14 AM UTC

Fixed in <http://trac.webkit.org/projects/webkit/changeset/27766>.

Eric Seidel (no email)

Comment 4 Wednesday, November 14, 2007 6:33:44 PM UTC

Nice.

Note You need to log in before you can comment on or make changes to this bug.