Bug 13371 - DumpRenderTree --pixel-tests renders each test twice
Summary: DumpRenderTree --pixel-tests renders each test twice
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-17 04:02 PDT by mitz
Modified: 2007-11-14 10:33 PST (History)
0 users

See Also:

Attachments
Paint only once (unless testing repaint) (4.35 KB, patch)
2007-11-13 16:20 PST, mitz 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2007-04-17 04:02:31 PDT 
Since WebKit is now supposed to paint on load (currently disabled because of <rdar://problem/5092361> but simulated by DumpRenderTree), DumpRenderTree ends up rendering each test to the window in addition to rendering to the offscreen buffer.
Comment 1 mitz 2007-11-13 16:20:00 PST 
Created attachment 17244 [details]
Paint only once (unless testing repaint)

I verified that the painting code is run in --leaks mode simply by using Expose to bring in DRT's "offscreen" window and verifying that the tests are being rendered. I also verified that repaint tests work.
Comment 2 Darin Adler 2007-11-13 16:47:13 PST 
Comment on attachment 17244 [details]
Paint only once (unless testing repaint)

r=me
Comment 3 mitz 2007-11-13 16:50:14 PST 
Fixed in <http://trac.webkit.org/projects/webkit/changeset/27766>.
Comment 4 Eric Seidel (no email) 2007-11-14 10:33:44 PST 
Nice.