Bug 133698

Summary:

Prediction propagator should make sure everyone knows that a variable that is in an argument position where other versions of that variable are not MachineInts cannot possibly be flushed as Int52

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam, simon.fraser

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	ggaren: review+

Filip Pizlo

Reported 2014-06-10 14:12:24 PDT

Patch forthcoming. This is hilariously related to an ancient bug, although that one only causes a recompilation storm and not a compiler crash: https://bugs.webkit.org/show_bug.cgi?id=109511 <rdar://problem/17127906>

Attachments
the patch (5.23 KB, patch) 2014-06-10 14:15 PDT, Filip Pizlo	ggaren: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2014-06-10 14:15:14 PDT

Created attachment 232814 [details] the patch

Geoffrey Garen

Comment 2 2014-06-10 14:23:49 PDT

Comment on attachment 232814 [details] the patch r=me

Mark Hahnenberg

Comment 3 2014-06-10 14:26:33 PDT

Comment on attachment 232814 [details] the patch r=me too

Filip Pizlo

Comment 4 2014-06-10 18:54:49 PDT

Landed in http://trac.webkit.org/changeset/169787

Note You need to log in before you can comment on or make changes to this bug.