Bug 133698 - Prediction propagator should make sure everyone knows that a variable that is in an argument position where other versions of that variable are not MachineInts cannot possibly be flushed as Int52
Summary: Prediction propagator should make sure everyone knows that a variable that is...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-10 14:12 PDT by Filip Pizlo
Modified: 2014-06-10 18:54 PDT (History)
8 users (show)

See Also:

Attachments
the patch (5.23 KB, patch)
2014-06-10 14:15 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-06-10 14:12:24 PDT 
Patch forthcoming.

This is hilariously related to an ancient bug, although that one only causes a recompilation storm and not a compiler crash: https://bugs.webkit.org/show_bug.cgi?id=109511

<rdar://problem/17127906>
Comment 1 Filip Pizlo 2014-06-10 14:15:14 PDT 
Created attachment 232814 [details]
the patch
Comment 2 Geoffrey Garen 2014-06-10 14:23:49 PDT 
Comment on attachment 232814 [details]
the patch

r=me
Comment 3 Mark Hahnenberg 2014-06-10 14:26:33 PDT 
Comment on attachment 232814 [details]
the patch

r=me too
Comment 4 Filip Pizlo 2014-06-10 18:54:49 PDT 
Landed in http://trac.webkit.org/changeset/169787