Bug 133697

Summary:

[Cocoa] Handling authentication challenges should not require multiple delegate methods

Product:

WebKit

Reporter:

mitz

Component:

WebKit2

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Add -[WKNavigationDelegatePrivate _webView:willSendRequestForAuthenticationChallenge:]	none
Add -[WKNavigationDelegatePrivate _webView:willSendRequestForAuthenticationChallenge:]	none
Add -[WKNavigationDelegatePrivate _webView:willSendRequestForAuthenticationChallenge:]	none

mitz

Reported 2014-06-10 13:51:44 PDT

NSURLAuthenticationChallengeSender now makes it possible to respond to authentication challenges with a single delegate method. We can add that kind of delegate method to WKNavigationDelegate.

Attachments
Add -[WKNavigationDelegatePrivate _webView:willSendRequestForAuthenticationChallenge:] (27.40 KB, patch) 2014-06-10 14:43 PDT, mitz	no flags	Details Formatted Diff Diff
Add -[WKNavigationDelegatePrivate _webView:willSendRequestForAuthenticationChallenge:] (34.54 KB, patch) 2014-06-10 16:04 PDT, mitz	no flags	Details Formatted Diff Diff
Add -[WKNavigationDelegatePrivate _webView:willSendRequestForAuthenticationChallenge:] (35.15 KB, patch) 2014-06-10 16:20 PDT, mitz	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2014-06-10 14:43:18 PDT

Created attachment 232821 [details] Add -[WKNavigationDelegatePrivate _webView:willSendRequestForAuthenticationChallenge:]

mitz

Comment 2 2014-06-10 16:04:08 PDT

Created attachment 232826 [details] Add -[WKNavigationDelegatePrivate _webView:willSendRequestForAuthenticationChallenge:]

mitz

Comment 3 2014-06-10 16:08:19 PDT

Comment on attachment 232826 [details] Add -[WKNavigationDelegatePrivate _webView:willSendRequestForAuthenticationChallenge:] This just contains build fixes on top of the previous patch, which Anders has reviewed.

mitz

Comment 4 2014-06-10 16:20:19 PDT

Created attachment 232827 [details] Add -[WKNavigationDelegatePrivate _webView:willSendRequestForAuthenticationChallenge:]

mitz

Comment 5 2014-06-10 17:02:02 PDT

Fixed in <http://trac.webkit.org/r169782>.

Note You need to log in before you can comment on or make changes to this bug.