Bug 133697

Summary: [Cocoa] Handling authentication challenges should not require multiple delegate methods
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Add -[WKNavigationDelegatePrivate _webView:willSendRequestForAuthenticationChallenge:]
none
Add -[WKNavigationDelegatePrivate _webView:willSendRequestForAuthenticationChallenge:]
none
Add -[WKNavigationDelegatePrivate _webView:willSendRequestForAuthenticationChallenge:] none

Description mitz 2014-06-10 13:51:44 PDT
NSURLAuthenticationChallengeSender now makes it possible to respond to authentication challenges with a single delegate method. We can add that kind of delegate method to WKNavigationDelegate.
Comment 1 mitz 2014-06-10 14:43:18 PDT
Created attachment 232821 [details]
Add -[WKNavigationDelegatePrivate _webView:willSendRequestForAuthenticationChallenge:]
Comment 2 mitz 2014-06-10 16:04:08 PDT
Created attachment 232826 [details]
Add -[WKNavigationDelegatePrivate _webView:willSendRequestForAuthenticationChallenge:]
Comment 3 mitz 2014-06-10 16:08:19 PDT
Comment on attachment 232826 [details]
Add -[WKNavigationDelegatePrivate _webView:willSendRequestForAuthenticationChallenge:]

This just contains build fixes on top of the previous patch, which Anders has reviewed.
Comment 4 mitz 2014-06-10 16:20:19 PDT
Created attachment 232827 [details]
Add -[WKNavigationDelegatePrivate _webView:willSendRequestForAuthenticationChallenge:]
Comment 5 mitz 2014-06-10 17:02:02 PDT
Fixed in <http://trac.webkit.org/r169782>.