Bug 133665

Summary: Work towards having frames in the scrolling tree
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, cmarcelo, commit-queue, esprehn+autocc, fred.wang, glenn, jamesr, kondapallykalyan, luiz, simon.fraser, thorton, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149264, 133694, 173405    
Attachments:
Description Flags
Patch thorton: review+

Description Simon Fraser (smfr) 2014-06-09 16:43:54 PDT
Work towards having frames in the scrolling tree
Comment 1 Simon Fraser (smfr) 2014-06-09 17:10:54 PDT
Created attachment 232750 [details]
Patch
Comment 2 Tim Horton 2014-06-09 17:20:39 PDT
Comment on attachment 232750 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232750&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:3611
> +    RenderElement* frameRenderer = ownerElement ? ownerElement->renderer() : 0;

nullptr

> Source/WebCore/rendering/RenderView.cpp:842
> +    // FIXME: view() is just *this here.

why the fixme instead of fixing?
Comment 3 Simon Fraser (smfr) 2014-06-09 17:39:27 PDT
https://trac.webkit.org/r169733