Bug 133658

Summary:

Flash video controls hit-test incorrectly after changing topContentInset

Product:

WebKit

Reporter:

Beth Dakin <bdakin>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, bdakin, sam, thorton

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	andersca: review-
Patch	andersca: review+

Description Beth Dakin 2014-06-09 14:56:12 PDT

Flash video controls hit-test incorrectly after changing topContentInset

<rdar://problem/16978590>

Comment 1 Beth Dakin 2014-06-09 15:01:09 PDT

Created attachment 232735 [details]
Patch

Comment 2 Anders Carlsson 2014-06-09 15:02:25 PDT

Comment on attachment 232735 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232735&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2109
> +    if (insetDidChange) {

Can use an early return here instead.

Comment 3 Beth Dakin 2014-06-09 15:05:25 PDT

Created attachment 232736 [details]
Patch

Comment 4 Beth Dakin 2014-06-09 15:31:44 PDT

Thanks Anders! http://trac.webkit.org/changeset/169724