Bug 133615

Summary: ScriptExecutionContext::Task parameters should always be rvalue references
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, darin, esprehn+autocc, kangil.han
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Description Zan Dobersek 2014-06-07 22:49:22 PDT 
ScriptExecutionContext::Task parameters should always be rvalue references
Comment 1 Zan Dobersek 2014-06-07 22:58:47 PDT 
Created attachment 232679 [details]
Patch
Comment 2 Darin Adler 2014-06-17 13:43:12 PDT 
Comment on attachment 232679 [details]
Patch

Wait, I am not sure this is a good idea. If the object really is move-only then it seems strange to change it to &&.
Comment 3 Darin Adler 2014-06-17 14:06:53 PDT 
Anders, what do you think of this from a coding style point of view?
Comment 4 Anders Carlsson 2014-06-17 14:24:15 PDT 
(In reply to comment #3)
> Anders, what do you think of this from a coding style point of view?

If it's move only it doesn't matter. I don't think it should be an rvalue reference in that case.
Comment 5 Zan Dobersek 2014-06-18 10:54:46 PDT 
Committed r170106: <http://trac.webkit.org/changeset/170106>
Comment 6 Zan Dobersek 2014-06-18 11:05:14 PDT 
Sorry, I missed the comments before landing.

I'll revert these and other ScriptExecutionContext::Task&& parameters in one go, in a different bug.