Bug 133591

Summary: advanceByCombiningCharacterSequence() can be simplified
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: Layout and RenderingAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Myles C. Maxfield
Reported 2014-06-06 16:57:36 PDT
It can use U16_NEXT() instead.
Attachments
Patch (1.94 KB, patch)
2014-06-23 20:15 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2014-06-23 20:15:49 PDT
Created attachment 233673 [details] Patch
Radar WebKit Bug Importer
Comment 2 2014-06-23 20:19:32 PDT
<rdar://problem/17430091>
WebKit Commit Bot
Comment 3 2014-06-24 16:32:56 PDT
Comment on attachment 233673 [details] Patch Clearing flags on attachment: 233673 Committed r170402: <http://trac.webkit.org/changeset/170402>
WebKit Commit Bot
Comment 4 2014-06-24 16:32:59 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 5 2014-06-25 19:34:08 PDT
Comment on attachment 233673 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233673&action=review > Source/WebCore/platform/graphics/mac/ComplexTextController.cpp:275 > + if (U16_IS_SURROGATE(baseCharacter)) Technically this is incorrect. Since the argument is a UChar32, it should just be U_IS_SURROGATE. But in practice this will work since U16_IS_SURROGATE just calls U_IS_SURROGATE.
Note You need to log in before you can comment on or make changes to this bug.