Summary: | Automatic text track selection can select more than one track | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||
Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, bunhere, calvaris, cdumez, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, philipj, sergio, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Eric Carlson
2014-06-06 16:39:18 PDT
Created attachment 232637 [details]
Proposed patch.
Comment on attachment 232637 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=232637&action=review r=me > Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:774 > + if (kind != TextTrack::captionsKeyword() && kind != TextTrack::descriptionsKeyword() && kind != TextTrack::subtitlesKeyword()) This pattern gets used in a few places. Someday we should make some kind of "TextTrack::shouldDisplayKind(kind)" or something. Comment on attachment 232637 [details] Proposed patch. Clearing flags on attachment: 232637 Committed r169725: <http://trac.webkit.org/changeset/169725> All reviewed patches have been landed. Closing bug. |