Bug 133590 - Automatic text track selection can select more than one track
Summary: Automatic text track selection can select more than one track
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-06 16:39 PDT by Eric Carlson
Modified: 2014-06-09 15:57 PDT (History)
12 users (show)

See Also:

Attachments
Proposed patch. (10.58 KB, patch)
2014-06-06 17:06 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2014-06-06 16:39:18 PDT 
If the automatic text track selection logic chooses a track that is not in the user's preferred language, adding a new track in the user's selected language should disable the first track.
Comment 1 Eric Carlson 2014-06-06 17:06:15 PDT 
Created attachment 232637 [details]
Proposed patch.
Comment 2 Brent Fulgham 2014-06-06 17:21:00 PDT 
Comment on attachment 232637 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=232637&action=review

r=me

> Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:774
> +        if (kind != TextTrack::captionsKeyword() && kind != TextTrack::descriptionsKeyword() && kind != TextTrack::subtitlesKeyword())

This pattern gets used in a few places. Someday we should make some kind of "TextTrack::shouldDisplayKind(kind)" or something.
Comment 3 Radar WebKit Bug Importer 2014-06-09 15:27:36 PDT 
<rdar://problem/17240466>
Comment 4 WebKit Commit Bot 2014-06-09 15:57:11 PDT 
Comment on attachment 232637 [details]
Proposed patch.

Clearing flags on attachment: 232637

Committed r169725: <http://trac.webkit.org/changeset/169725>
Comment 5 WebKit Commit Bot 2014-06-09 15:57:16 PDT 
All reviewed patches have been landed.  Closing bug.