Bug 133573

Summary: [MediaStream] 'get' prefix is missing for capabilities and constraints.
Product: WebKit Reporter: Kiran <kiran.guduru>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, eric.carlson, esprehn+autocc, glenn, hta, jer.noble, kondapallykalyan, lucas.de.marchi, philipj, sergio, tommyw
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[MediaStream] 'get' prefix is missing for capabilities() and constraints()
none
[MediaStream] 'get' prefix is missing for capabilities() and constraints() none

Description Kiran 2014-06-06 03:36:08 PDT
capabilities and constraints should be getCapabilities() and getConstraints() as per the spec [1].

[1] http://dev.w3.org/2011/webrtc/editor/getusermedia.html#dfn-getcapabilities
Comment 1 Kiran 2014-06-06 03:41:56 PDT
Created attachment 232609 [details]
[MediaStream] 'get' prefix is missing for capabilities() and constraints()

Modified the method names as per the spec.
Comment 2 WebKit Commit Bot 2014-06-06 03:43:19 PDT
Attachment 232609 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Kiran 2014-06-06 03:48:33 PDT
Created attachment 232610 [details]
[MediaStream] 'get' prefix is missing for capabilities() and constraints()

Updated the changeLog file by adding description instead of No new tests.
Comment 4 WebKit Commit Bot 2014-06-06 09:34:13 PDT
Comment on attachment 232610 [details]
[MediaStream] 'get' prefix is missing for capabilities() and constraints()

Clearing flags on attachment: 232610

Committed r169648: <http://trac.webkit.org/changeset/169648>
Comment 5 WebKit Commit Bot 2014-06-06 09:34:18 PDT
All reviewed patches have been landed.  Closing bug.