Bug 133573 - [MediaStream] 'get' prefix is missing for capabilities and constraints.
Summary: [MediaStream] 'get' prefix is missing for capabilities and constraints.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-06 03:36 PDT by Kiran
Modified: 2014-06-06 09:34 PDT (History)
12 users (show)

See Also:

Attachments
[MediaStream] 'get' prefix is missing for capabilities() and constraints() (7.61 KB, patch)
2014-06-06 03:41 PDT, Kiran 		no flags Details | Formatted Diff | Diff
[MediaStream] 'get' prefix is missing for capabilities() and constraints() (7.65 KB, patch)
2014-06-06 03:48 PDT, Kiran 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kiran 2014-06-06 03:36:08 PDT 
capabilities and constraints should be getCapabilities() and getConstraints() as per the spec [1].

[1] http://dev.w3.org/2011/webrtc/editor/getusermedia.html#dfn-getcapabilities
Comment 1 Kiran 2014-06-06 03:41:56 PDT 
Created attachment 232609 [details]
[MediaStream] 'get' prefix is missing for capabilities() and constraints()

Modified the method names as per the spec.
Comment 2 WebKit Commit Bot 2014-06-06 03:43:19 PDT 
Attachment 232609 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Kiran 2014-06-06 03:48:33 PDT 
Created attachment 232610 [details]
[MediaStream] 'get' prefix is missing for capabilities() and constraints()

Updated the changeLog file by adding description instead of No new tests.
Comment 4 WebKit Commit Bot 2014-06-06 09:34:13 PDT 
Comment on attachment 232610 [details]
[MediaStream] 'get' prefix is missing for capabilities() and constraints()

Clearing flags on attachment: 232610

Committed r169648: <http://trac.webkit.org/changeset/169648>
Comment 5 WebKit Commit Bot 2014-06-06 09:34:18 PDT 
All reviewed patches have been landed.  Closing bug.