Bug 133528

Summary:

SVGGlyphToPathTranslator ASSERTs when encountering a missing glyph in an SVG font

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

Layout and Rendering

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, d-r, esprehn+autocc, fmalita, glenn, gyuyoung.kim, jonlee, kondapallykalyan, pdr, schenney, sergio, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+

Description Myles C. Maxfield 2014-06-04 18:30:57 PDT

Currently an assert fires if you style text (possibly underlined, regarding text-decoration-skip: ink, and possibly not regarding simply drawing the text) and you supply a letter that is not contained within the SVG font.

Comment 1 Myles C. Maxfield 2014-06-04 18:45:03 PDT

<rdar://problem/17166642>

Comment 2 Myles C. Maxfield 2014-06-11 17:32:40 PDT

Created attachment 232923 [details]
Patch

Comment 3 Simon Fraser (smfr) 2014-06-11 17:59:16 PDT

Comment on attachment 232923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232923&action=review

> Source/WebCore/platform/graphics/mac/FontMac.mm:548
> +            // The advances will get all messed up if we do anything other than bail here.
> +            result.clear(); // Better to be consistent rather than half-correct

Maybe make the comments a bit less hilarious.

Comment 4 Myles C. Maxfield 2014-06-11 19:25:32 PDT

http://trac.webkit.org/changeset/169872