Bug 133528 - SVGGlyphToPathTranslator ASSERTs when encountering a missing glyph in an SVG font
Summary: SVGGlyphToPathTranslator ASSERTs when encountering a missing glyph in an SVG ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-04 18:30 PDT by Myles C. Maxfield
Modified: 2014-06-11 19:25 PDT (History)
15 users (show)

See Also:

Attachments
Patch (6.80 KB, patch)
2014-06-11 17:32 PDT, Myles C. Maxfield 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-06-04 18:30:57 PDT 
Currently an assert fires if you style text (possibly underlined, regarding text-decoration-skip: ink, and possibly not regarding simply drawing the text) and you supply a letter that is not contained within the SVG font.
Comment 1 Myles C. Maxfield 2014-06-04 18:45:03 PDT 
<rdar://problem/17166642>
Comment 2 Myles C. Maxfield 2014-06-11 17:32:40 PDT 
Created attachment 232923 [details]
Patch
Comment 3 Simon Fraser (smfr) 2014-06-11 17:59:16 PDT 
Comment on attachment 232923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232923&action=review

> Source/WebCore/platform/graphics/mac/FontMac.mm:548
> +            // The advances will get all messed up if we do anything other than bail here.
> +            result.clear(); // Better to be consistent rather than half-correct

Maybe make the comments a bit less hilarious.
Comment 4 Myles C. Maxfield 2014-06-11 19:25:32 PDT 
http://trac.webkit.org/changeset/169872