Bug 133526

Summary: REGRESSION (iOS WebKit2): Selection rect disappears on touch up on google result
Product: WebKit Reporter: Enrica Casucci <enrica>
Component: WebKit2Assignee: Enrica Casucci <enrica>
Status: CLOSED WONTFIX    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch benjamin: review+, benjamin: commit-queue-

Description Enrica Casucci 2014-06-04 14:40:57 PDT 
Tap and hold on an address after searching for a place in google.
Lifting the finger makes the  selection disappear.

<rdar://problem/16863448>
Comment 1 Enrica Casucci 2014-06-04 14:53:37 PDT 
Created attachment 232503 [details]
Patch
Comment 2 Benjamin Poulain 2014-06-04 15:33:16 PDT 
Comment on attachment 232503 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232503&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:755
> +- (void)cancelHighlight
> +{
> +    [_highlightLongPressGestureRecognizer cancel];
> +}

You can just expose _cancelLongPressGestureRecognizer. Or if you really need a separate call, use [self _cancelLongPressGestureRecognizer].
Comment 3 Enrica Casucci 2014-06-04 15:40:28 PDT 
(In reply to comment #2)
> (From update of attachment 232503 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=232503&action=review
> 
> > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:755
> > +- (void)cancelHighlight
> > +{
> > +    [_highlightLongPressGestureRecognizer cancel];
> > +}
> 
> You can just expose _cancelLongPressGestureRecognizer. Or if you really need a separate call, use [self _cancelLongPressGestureRecognizer].

I did not see that. I'll use that one directly. No need for this patch then. Thanks!