Bug 133503

Summary: Enable WebGL on Windows
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: benjamin, bfulgham, cmarcelo, cmarrin, commit-queue, dino, esprehn+autocc, gyuyoung.kim, kondapallykalyan, noam, roger_fong, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch bfulgham: review+, bfulgham: commit-queue-

Description Alex Christensen 2014-06-03 23:13:15 PDT 
I got WebGL working on Windows again.  Accelerated compositing still needs fixing for performance gains and antialiasing, but it works without it.
Comment 1 Alex Christensen 2014-06-03 23:24:29 PDT 
Created attachment 232467 [details]
Patch
Comment 2 WebKit Commit Bot 2014-06-03 23:26:59 PDT 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Brent Fulgham 2014-06-04 14:48:37 PDT 
Comment on attachment 232467 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232467&action=review

I think this looks good. Can you fix the date on the file I reference in these notes? r=me.

> Source/ThirdParty/ANGLE/include/EGL/eglsoftlinking.h:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

Copyright 2014, please!

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:686
> +    if (isAccelerated() && renderBox && renderBox->hasAcceleratedCompositing()) {

Since the default case is for accelerated to be true, should this just be an #if/def?
Comment 4 Alex Christensen 2014-06-04 16:35:03 PDT 
http://trac.webkit.org/changeset/169601
Comment 5 Brent Fulgham 2014-06-04 16:52:06 PDT 
<rdar://problem/8234826>
Comment 6 Alex Christensen 2014-06-04 17:15:22 PDT 
*** Bug 30625 has been marked as a duplicate of this bug. ***