Bug 133503

Summary: Enable WebGL on Windows
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: benjamin, bfulgham, cmarcelo, cmarrin, commit-queue, dino, esprehn+autocc, gyuyoung.kim, kondapallykalyan, noam, roger_fong, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch bfulgham: review+, bfulgham: commit-queue-

Alex Christensen
Reported 2014-06-03 23:13:15 PDT
I got WebGL working on Windows again. Accelerated compositing still needs fixing for performance gains and antialiasing, but it works without it.
Attachments
Patch (54.41 KB, patch)
2014-06-03 23:24 PDT, Alex Christensen 		bfulgham: review+
bfulgham: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2014-06-03 23:24:29 PDT
Created attachment 232467 [details] Patch
WebKit Commit Bot
Comment 2 2014-06-03 23:26:59 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Brent Fulgham
Comment 3 2014-06-04 14:48:37 PDT
Comment on attachment 232467 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232467&action=review I think this looks good. Can you fix the date on the file I reference in these notes? r=me. > Source/ThirdParty/ANGLE/include/EGL/eglsoftlinking.h:2 > + * Copyright (C) 2013 Apple Inc. All rights reserved. Copyright 2014, please! > Source/WebCore/html/canvas/WebGLRenderingContext.cpp:686 > + if (isAccelerated() && renderBox && renderBox->hasAcceleratedCompositing()) { Since the default case is for accelerated to be true, should this just be an #if/def?
Alex Christensen
Comment 4 2014-06-04 16:35:03 PDT
http://trac.webkit.org/changeset/169601
Brent Fulgham
Comment 5 2014-06-04 16:52:06 PDT
<rdar://problem/8234826>
Alex Christensen
Comment 6 2014-06-04 17:15:22 PDT
*** Bug 30625 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.