| Summary: | [CSS Shapes] Fix off by one in creating a RasterShape | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Bem Jones-Bey <bjonesbe> | ||||
| Component: | Layout and Rendering | Assignee: | Bem Jones-Bey <bjonesbe> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kondapallykalyan | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Bem Jones-Bey
2014-06-03 20:49:50 PDT
Note that crash is not a security issue because it is caught by a release assert in WTF::Vector. Created attachment 232463 [details]
Patch
Comment on attachment 232463 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232463&action=review > LayoutTests/ChangeLog:9 > + * fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-crash-expected.txt: Added. > + * fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-crash.html: Added. Would be nicer to do some kind of reference test instead, but maybe that's impractical. Comment on attachment 232463 [details] Patch Clearing flags on attachment: 232463 Committed r169604: <http://trac.webkit.org/changeset/169604> All reviewed patches have been landed. Closing bug. (In reply to comment #3) > (From update of attachment 232463 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=232463&action=review > > > LayoutTests/ChangeLog:9 > > + * fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-crash-expected.txt: Added. > > + * fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-crash.html: Added. > > Would be nicer to do some kind of reference test instead, but maybe that's impractical. Ref tests for image shapes with different combinations of margin, borders, padding and shape margin are forthcoming. I just wanted to get this one fixed ASAP since it's a crasher. Thanks for the review. |