Bug 133495

Summary:

Pasting multiple photos on iOS only pastes one photo

Product:

WebKit

Reporter:

Jon Honeycutt <jhoneycutt>

Component:

HTML Editing

Assignee:

Jon Honeycutt <jhoneycutt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, benjamin, enrica, rniwa

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ap: review+

Jon Honeycutt

Reported 2014-06-03 17:53:59 PDT

Pasting multiple photos in Mail's compose mail sheet only pastes one photo. <rdar://problem/16138616>

Attachments
Patch (3.03 KB, patch) 2014-06-03 18:10 PDT, Jon Honeycutt	ap: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jon Honeycutt

Comment 1 2014-06-03 18:10:33 PDT

Created attachment 232455 [details] Patch

Jon Honeycutt

Comment 2 2014-06-04 13:47:16 PDT

Committed r169594: <http://trac.webkit.org/changeset/169594>

Alexey Proskuryakov

Comment 3 2014-06-05 16:40:42 PDT

I happened to look into the same code today, and now I don't understand something. Pasteboard::read() already iterates over all items, and adds fragments for them. So we do we even need documentFragmentFromDelegate() before calling webContentFromPasteboard(), which calls Pasteboard::read()?

Jon Honeycutt

Comment 4 2014-06-06 14:57:41 PDT

(In reply to comment #3) > I happened to look into the same code today, and now I don't understand something. > > Pasteboard::read() already iterates over all items, and adds fragments for them. So we do we even need documentFragmentFromDelegate() before calling webContentFromPasteboard(), which calls Pasteboard::read()? Mail uses this delegate call to (at least) resize the images that are pasted. I'm not sure if it does anything else.

Note You need to log in before you can comment on or make changes to this bug.