Bug 133495 - Pasting multiple photos on iOS only pastes one photo
Summary: Pasting multiple photos on iOS only pastes one photo
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Honeycutt
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-03 17:53 PDT by Jon Honeycutt
Modified: 2014-06-06 14:57 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.03 KB, patch)
2014-06-03 18:10 PDT, Jon Honeycutt 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Honeycutt 2014-06-03 17:53:59 PDT 
Pasting multiple photos in Mail's compose mail sheet only pastes one photo.

<rdar://problem/16138616>
Comment 1 Jon Honeycutt 2014-06-03 18:10:33 PDT 
Created attachment 232455 [details]
Patch
Comment 2 Jon Honeycutt 2014-06-04 13:47:16 PDT 
Committed r169594: <http://trac.webkit.org/changeset/169594>
Comment 3 Alexey Proskuryakov 2014-06-05 16:40:42 PDT 
I happened to look into the same code today, and now I don't understand something.

Pasteboard::read() already iterates over all items, and adds fragments for them. So we do we even need documentFragmentFromDelegate() before calling webContentFromPasteboard(), which calls Pasteboard::read()?
Comment 4 Jon Honeycutt 2014-06-06 14:57:41 PDT 
(In reply to comment #3)
> I happened to look into the same code today, and now I don't understand something.
> 
> Pasteboard::read() already iterates over all items, and adds fragments for them. So we do we even need documentFragmentFromDelegate() before calling webContentFromPasteboard(), which calls Pasteboard::read()?

Mail uses this delegate call to (at least) resize the images that are pasted. I'm not sure if it does anything else.