| Summary: | Fix some corner cases of :hover and :active in quirks mode | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||||||
| Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, kling, rniwa, ysuzuki | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Benjamin Poulain
2014-06-03 16:40:14 PDT
Created attachment 232450 [details]
Patch
Comment on attachment 232450 [details] Patch Attachment 232450 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6196910264156160 New failing tests: media/W3C/video/src/src_reflects_attribute_not_source_elements.html Created attachment 232454 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 232450 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232450&action=review r=me. The test failure seems totally unrelated. > Source/WebCore/ChangeLog:17 > + This patch moves the detection quirks mode exception code from the code generator to the Fragment generator. "detection quirks mode exception code" wut Comment on attachment 232450 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232450&action=review The patch looks great to me! > Source/WebCore/cssjit/SelectorCompiler.cpp:536 > + fragment.onlyMatchesLinksInQuirksMode = false; Is it unnecessary to check `tagName == anyQname()`? (In reply to comment #5) > (From update of attachment 232450 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=232450&action=review > > The patch looks great to me! > > > Source/WebCore/cssjit/SelectorCompiler.cpp:536 > > + fragment.onlyMatchesLinksInQuirksMode = false; > > Is it unnecessary to check `tagName == anyQname()`? You are right, I'll add this check when landing. Created attachment 232466 [details]
Patch for landing
Committed r169585: <http://trac.webkit.org/changeset/169585> |