Summary: | svn-create-patch should support -c NNNNN argument to pull a patch from svn | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED WONTFIX | ||||||
Severity: | Normal | CC: | ahmad.saleem792, darin | ||||
Priority: | P2 | ||||||
Version: | 523.x (Safari 3) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2007-04-13 19:46:05 PDT
Created attachment 14045 [details]
WIP v1
WIP. I don't want to lose these changes! They need some more time to bake, and there are a few edge cases (like added binary files) that need to be addressed.
Note that this fix will also support a simple "-r NNNNN" argument that "knows" you want to generate a diff for revision "NNNNN" and will subtract one from that revision to create a range. Brilliant! (In reply to comment #1) > WIP. I don't want to lose these changes! They need some more time to bake, > and there are a few edge cases (like added binary files) that need to be > addressed. I may also move the "isBinary" check from the generateFileList*() subroutines to inside generateDiff() since it will be obvious when a file is a binary file (from the previous diff output), and it will save some time running more svn commands for each file! Nits on WIP v1 patch: 1. Broke added files in working copy. 2. "-rNNNNN" without a space doesn't work. *** Bug 15041 has been marked as a duplicate of this bug. *** GitHub is now defect - SVN is gone. Do we need this? I think we don’t and can close this. Thanks Darin. Marked as 'RESOLVED WONTFIX'. |