Bug 133486

Summary:

Add a background color to Speedometer's iframe

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

commit-queue, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	rniwa: review-, rniwa: commit-queue-

Timothy Hatcher

Reported 2014-06-03 11:26:00 PDT

The frame flashes to black between tests on a slower network. It looks better with a light gray background.

Attachments
Patch (1.25 KB, patch) 2014-06-03 11:27 PDT, Timothy Hatcher	rniwa: review- rniwa: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Timothy Hatcher

Comment 1 2014-06-03 11:27:14 PDT

Created attachment 232434 [details] Patch

Mark Lam

Comment 2 2014-06-03 12:28:41 PDT

Comment on attachment 232434 [details] Patch rs=me

Ryosuke Niwa

Comment 3 2014-06-03 12:45:11 PDT

Comment on attachment 232434 [details] Patch We can't do this. Adding z-index would affect the benchmark.

Ryosuke Niwa

Comment 4 2014-06-03 12:47:58 PDT

Also, if we're making change of this sort, we need to bump up the version number. Adding a background color can significantly affect the painting & compositing performance.

Note You need to log in before you can comment on or make changes to this bug.