Bug 133442

Summary: Make GraphicsContext::drawImage, drawTiledImage and drawImageBuffer take Image& instead of Image*
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: ahmad.saleem792
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
All image buffer are as 'ImageBuffer&' none

zalan
Reported 2014-06-01 20:27:41 PDT
void drawImage(Image*, ColorSpace, const FloatPoint& destination, const ImagePaintingContext& = ImagePaintingContext()); void drawImage(Image*, ColorSpace, const FloatRect& destination, const ImagePaintingContext& = ImagePaintingContext()); void drawImage(Image*, ColorSpace, const FloatRect& destination, const FloatRect& source, const ImagePaintingContext& = ImagePaintingContext()); void drawTiledImage(Image*, ColorSpace, const FloatRect& destination, const FloatPoint& source, const FloatSize& tileSize, const ImagePaintingContext& = ImagePaintingContext()); void drawTiledImage(Image*, ColorSpace, const FloatRect& destination, const FloatRect& source, const FloatSize& tileScaleFactor, Image::TileRule, Image::TileRule, const ImagePaintingContext& = ImagePaintingContext()); void drawImageBuffer(ImageBuffer*, ColorSpace, const FloatPoint& destination, const ImagePaintingContext& = ImagePaintingContext()); void drawImageBuffer(ImageBuffer*, ColorSpace, const FloatRect& destination, const ImagePaintingContext& = ImagePaintingContext()); void drawImageBuffer(ImageBuffer*, ColorSpace, const FloatRect& destination, const FloatRect& source, const ImagePaintingContext& = ImagePaintingContext());
Attachments
All image buffer are as 'ImageBuffer&' (617.17 KB, image/png)
2023-12-02 10:12 PST, Ahmad Saleem 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Ahmad Saleem
Comment 1 2023-12-02 10:12:41 PST
Created attachment 468839 [details] All image buffer are as 'ImageBuffer&' @Alan - from quick search on 'searchfox.org' with following keyword as shown in the picture. All of them are 'ImageBuffer&' instead of 'ImageBuffer*'. Do we need this anymore?
zalan
Comment 2 2023-12-04 13:33:48 PST
probably not, thanks for looking into this.
Note You need to log in before you can comment on or make changes to this bug.