Bug 133430

Summary: Web Replay: don't encode/decode primitive types that lack explicit sizes
Product: WebKit Reporter: Brian Burg <burg>
Component: WebCore Misc.Assignee: Brian Burg <burg>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, darin, joepeck, ossy, timothy, zsborbely.u-szeged
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Brian Burg
Reported 2014-05-31 21:53:19 PDT
We currently serialize unsigned int and int fields for some C++ types and replay inputs. To reduce ambiguity as to what is being serialized, we should instead cast any such type to [u]int{32,64}_t and remove the specializations for unsigned int and int.
Attachments
patch (12.18 KB, patch)
2014-06-07 21:15 PDT, Brian Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2014-06-04 03:00:19 PDT
*** Bug 133400 has been marked as a duplicate of this bug. ***
Brian Burg
Comment 2 2014-06-07 21:15:03 PDT
Created attachment 232675 [details] patch
Csaba Osztrogonác
Comment 3 2014-07-24 02:48:48 PDT
Anders, Darin, could you review this old patch, please? It is still needed to fix the web replay build on Linux.
WebKit Commit Bot
Comment 4 2014-07-24 15:11:36 PDT
Comment on attachment 232675 [details] patch Clearing flags on attachment: 232675 Committed r171528: <http://trac.webkit.org/changeset/171528>
WebKit Commit Bot
Comment 5 2014-07-24 15:11:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.