| Summary: | Web Replay: don't encode/decode primitive types that lack explicit sizes | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brian Burg <burg> | ||||
| Component: | WebCore Misc. | Assignee: | Brian Burg <burg> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, commit-queue, darin, joepeck, ossy, timothy, zsborbely.u-szeged | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
*** Bug 133400 has been marked as a duplicate of this bug. *** Created attachment 232675 [details]
patch
Anders, Darin, could you review this old patch, please? It is still needed to fix the web replay build on Linux. Comment on attachment 232675 [details] patch Clearing flags on attachment: 232675 Committed r171528: <http://trac.webkit.org/changeset/171528> All reviewed patches have been landed. Closing bug. |
We currently serialize unsigned int and int fields for some C++ types and replay inputs. To reduce ambiguity as to what is being serialized, we should instead cast any such type to [u]int{32,64}_t and remove the specializations for unsigned int and int.