Summary: | `currentColor` computes to the same colour on all elements, even if 'color' is inherited differently | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chauncey McAskill <shimoroka> | ||||
Component: | CSS | Assignee: | Benjamin Poulain <benjamin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, kling | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
URL: | http://jsfiddle.net/RDf4m/2/ | ||||||
Attachments: |
|
Description
Chauncey McAskill
2014-05-31 07:00:36 PDT
Created attachment 249678 [details]
Patch
Comment on attachment 249678 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249678&action=review > Source/WebCore/css/StyleResolver.cpp:264 > + const StyleProperties::PropertyReference current = properties.propertyAt(i); I suggest auto here. Also, the const doesn’t add anything. > Source/WebCore/css/StyleResolver.cpp:1718 > + for (const auto& matchedProperties : matchResult.matchedProperties()) { I don’t think you needed to add this const here. I believe would be const automatically. Committed r182130: <http://trac.webkit.org/changeset/182130> |