Bug 133413

Summary: REGRESSION (WebKit2): space space to insert period doesn't work in web forms
Product: WebKit Reporter: Enrica Casucci <enrica>
Component: WebKit2Assignee: Enrica Casucci <enrica>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch that fixes EWS benjamin: review+, benjamin: commit-queue-

Description Enrica Casucci 2014-05-30 16:08:02 PDT 
Any input field in Safari shows the problem, using the on-screen keyboard.

<rdar://problem/16948333>
Comment 1 Enrica Casucci 2014-05-30 16:23:51 PDT 
Created attachment 232308 [details]
Patch
Comment 2 Enrica Casucci 2014-05-30 16:36:45 PDT 
I've fixed the EWS failures.
Comment 3 Enrica Casucci 2014-05-30 16:39:08 PDT 
Created attachment 232310 [details]
Patch that fixes EWS
Comment 4 Benjamin Poulain 2014-05-30 16:45:28 PDT 
Comment on attachment 232310 [details]
Patch that fixes EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=232310&action=review

> Source/WebCore/editing/VisibleUnits.cpp:1819
> +// The elements in the returned vector are:
> +// 0 - the character after the given position (if it exists)
> +// 1 - the character before the given position (if it exists)
> +// 2 - the character before the position prior to the given position (if it exists).

Let's make the return value a struct. That way you can name all the values, which is gonna be easier to understand at the call sites.
Comment 5 Enrica Casucci 2014-05-30 17:13:48 PDT 
Landed the change that addresses Ben's comments.
Committed revision 169500.
Comment 6 Darin Adler 2014-05-30 18:05:54 PDT 
Comment on attachment 232310 [details]
Patch that fixes EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=232310&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2488
> +    const UChar noBreakSpace = 0x00A0;

CharacterNames.h already has this constant. Can’t we include that instead of adding a new declaration?
Comment 7 Enrica Casucci 2014-06-02 13:43:50 PDT 
Removed unwanted changes.
Committed revision 169543