Bug 133403 – [GTK] Unsupported browser in www.icloud.com

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Sergio Villar Senin]

Just to keep track of broken sites.

[Sergio Villar Senin]

So the problem is basically that in the UA string we need to add the "Version/X" thing, and this is very important, *before* the "Safari/X" part, otherwise it won't be recognized as a valid browser UA.

Note that according to http://www.useragentstring.com/pages/Safari/, "Version/X" is always located before "Safari/X" since it was introduced in Safari v3.0.

[Sergio Villar Senin]

Created attachment 232870 [details]
Patch

[Martin Robinson]

Comment on attachment 232870 [details]
Patch

Yeah, omitting the version is pretty bogus. We just need to keep it up to date. Perhaps we can make it equal the current version of Safari which better matches our feature profile.

[Sergio Villar Senin]

(In reply to comment #3)
> (From update of attachment 232870 [details])
> Yeah, omitting the version is pretty bogus. We just need to keep it up to date. Perhaps we can make it equal the current version of Safari which better matches our feature profile.

For sure, I tried to be a bit conservative and left 6.0. It was released with Mountain Lion back in 2012, but we might consider switching to Safari 7/6.1 which was released last year for Mavericks, Lion and Mountain Lion. We should be fine. WDYT?

[Martin Robinson]

(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 232870 [details] [details])
> > Yeah, omitting the version is pretty bogus. We just need to keep it up to date. Perhaps we can make it equal the current version of Safari which better matches our feature profile.
> 
> For sure, I tried to be a bit conservative and left 6.0. It was released with Mountain Lion back in 2012, but we might consider switching to Safari 7/6.1 which was released last year for Mavericks, Lion and Mountain Lion. We should be fine. WDYT?

I think we should go with 8 (or 7 if that doesn't work). 8 should have WebGL turned on by default.

[Sergio Villar Senin]

Created attachment 232889 [details]
Patch

Claim to be Safari 8

[Martin Robinson]

Comment on attachment 232889 [details]
Patch

Let's give it a shot. We can always back down to 7, if we need.

[Carlos Garcia Campos]

Comment on attachment 232889 [details]
Patch

Please, update the unit test before landing. See Tools/TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp

[Carlos Garcia Campos]

Comment on attachment 232889 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232889&action=review

Please, update the unit test before landing. See Tools/TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp

> Source/WebCore/platform/gtk/UserAgentGtk.cpp:141
> -    uaString.appendLiteral(" (KHTML, like Gecko) Safari/");
> +    uaString.appendLiteral(" (KHTML, like Gecko) Version/8.0 Safari/");

Could you also add a comment here including the URL of this bug, please?

[Sergio Villar Senin]

Committed r169887: <http://trac.webkit.org/changeset/169887>