Bug 133387

Summary:

Compatibility hack to make GitX less crashy

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

dev+webkit, ggaren, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
the patch.	ggaren: review-

Description Mark Lam 2014-05-29 14:19:25 PDT

The GitX app is using WebCore on a different thread than the main thread.  This results in crashes because WebKit is a main-thread only API.  This patch implements a MAC only hack to make GitX less crashy by forcing the use of the JSLock when entering the JSC VM if the app bundle is GitX.

Comment 1 Mark Lam 2014-05-29 14:19:57 PDT

<rdar://problem/17008429>

Comment 2 Geoffrey Garen 2014-05-29 15:09:04 PDT

GitX bug: <http://gitx.lighthouseapp.com/projects/17830-gitx/tickets/321-gitx-sometimes-crashes-beneath-pbwebhistorycontroller-preferenceschanged-on-a-secondary-thread>.

Comment 3 Mark Lam 2014-05-29 15:17:28 PDT

Created attachment 232266 [details]
the patch.

Comment 4 Geoffrey Garen 2014-05-29 15:33:19 PDT

Comment on attachment 232266 [details]
the patch.

Alexey and MarkR discovered that this was a temporary regression caused by a notification firing on a secondary thread. We don't need this workaround. We need the notification to fire on the main thread instead.