Bug 133376

Summary: Remove repetitive header in HTMLInputElement.cpp
Product: WebKit Reporter: Prashant Hiremath <hiremathprashants>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, stavila
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Prashant Hiremath
Reported 2014-05-29 05:28:13 PDT
RuntimeEnabledFeatures.h header file is added twice in file, So removing it. Also fixing webkit-style fix in file.
Attachments
Patch (1.48 KB, patch)
2014-05-29 05:30 PDT, Prashant Hiremath 		no flags
DetailsFormatted DiffDiff
Patch (1.51 KB, patch)
2014-05-29 05:39 PDT, Prashant Hiremath 		no flags
DetailsFormatted DiffDiff
Patch (1.06 KB, patch)
2014-05-29 19:37 PDT, Prashant Hiremath 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Prashant Hiremath
Comment 1 2014-05-29 05:30:58 PDT
Created attachment 232242 [details] Patch proposed patch
WebKit Commit Bot
Comment 2 2014-05-29 05:32:07 PDT
Attachment 232242 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Prashant Hiremath
Comment 3 2014-05-29 05:39:26 PDT
Created attachment 232243 [details] Patch Fixed ChangeLog Error
Radu Stavila
Comment 4 2014-05-29 06:06:09 PDT
Comment on attachment 232243 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232243&action=review > Source/WebCore/html/HTMLInputElement.cpp:856 > if (renderer() && renderer()->style().hasAppearance()) Altough this is a correct style fix, I think you should stick to changes relevant to this particular issue (e.g. just the header inclusion removal)
Prashant Hiremath
Comment 5 2014-05-29 19:37:43 PDT
Created attachment 232279 [details] Patch Removed Repeative headers only
WebKit Commit Bot
Comment 6 2014-05-30 12:27:25 PDT
Comment on attachment 232279 [details] Patch Clearing flags on attachment: 232279 Committed r169491: <http://trac.webkit.org/changeset/169491>
WebKit Commit Bot
Comment 7 2014-05-30 12:27:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.