| Summary: | Remove repetitive header in HTMLInputElement.cpp | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Prashant Hiremath <hiremathprashants> | ||||||||
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, stavila | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Prashant Hiremath
2014-05-29 05:28:13 PDT
Created attachment 232242 [details]
Patch
proposed patch
Attachment 232242 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 232243 [details]
Patch
Fixed ChangeLog Error
Comment on attachment 232243 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232243&action=review > Source/WebCore/html/HTMLInputElement.cpp:856 > if (renderer() && renderer()->style().hasAppearance()) Altough this is a correct style fix, I think you should stick to changes relevant to this particular issue (e.g. just the header inclusion removal) Created attachment 232279 [details]
Patch
Removed Repeative headers only
Comment on attachment 232279 [details] Patch Clearing flags on attachment: 232279 Committed r169491: <http://trac.webkit.org/changeset/169491> All reviewed patches have been landed. Closing bug. |