| Summary: | Pass C++11 lambdas to callOnMainThread() calls in IconDatabase | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, japhet | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Zan Dobersek
2014-05-29 03:55:01 PDT
Created attachment 232240 [details]
Patch
Comment on attachment 232240 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232240&action=review > Source/WebCore/loader/icon/IconDatabase.cpp:2160 > + ImportedIconURLForPageURLWorkItem* itemPtr = new ImportedIconURLForPageURLWorkItem(m_client, pageURL); Does this allocation need to be done in the icon sync thread? Can it be done on the main thread instead? > Source/WebCore/loader/icon/IconDatabase.cpp:2171 > + ImportedIconDataForPageURLWorkItem* itemPtr = new ImportedIconDataForPageURLWorkItem(m_client, pageURL); Does this allocation need to be done in the icon sync thread? Can it be done on the main thread instead? > Source/WebCore/loader/icon/IconDatabase.cpp:2182 > + RemovedAllIconsWorkItem* itemPtr = new RemovedAllIconsWorkItem(m_client); Does this allocation need to be done in the icon sync thread? Can it be done on the main thread instead? > Source/WebCore/loader/icon/IconDatabase.cpp:2193 > + FinishedURLImport* itemPtr = new FinishedURLImport(m_client); Does this allocation need to be done in the icon sync thread? Can it be done on the main thread instead? Created attachment 232530 [details]
Patch
(In reply to comment #2) > (From update of attachment 232240 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=232240&action=review > > > Source/WebCore/loader/icon/IconDatabase.cpp:2160 > > + ImportedIconURLForPageURLWorkItem* itemPtr = new ImportedIconURLForPageURLWorkItem(m_client, pageURL); > > Does this allocation need to be done in the icon sync thread? Can it be done on the main thread instead? I went on and removed all of these classes as they were just calling a specific method on the IconDatabaseClient in their performWork() override. Requesting a re-review because of that. Comment on attachment 232530 [details] Patch Clearing flags on attachment: 232530 Committed r169674: <http://trac.webkit.org/changeset/169674> All reviewed patches have been landed. Closing bug. |