Bug 133367

Summary: AX: Add support for ARIA 1.1 'none' role
Product: WebKit Reporter: James Craig <jcraig>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jdiggs, mario, richschwer, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch to add support for the 'none' role in ARIA 1.1
cfleizach: review-
Updated patch with change log
none
Updated patch with change log
timbrook: review+
Updated patch with change log
none
svn compatible patch
none
adds aria 'none' role
none
Added 'none' role
none
added 'none' role
none
added 'none' role none

Description James Craig 2014-05-28 18:19:51 PDT
"none" is a synonym of "presentation" in the ARIA 1.1 role list.

http://rawgit.com/w3c/aria/master/spec/aria.html#none
Comment 1 Radar WebKit Bug Importer 2014-05-28 18:20:13 PDT
<rdar://problem/17060103>
Comment 2 Michael Timbrook 2014-06-04 12:58:48 PDT
Created attachment 232493 [details]
Patch to add support for the 'none' role in ARIA 1.1
Comment 3 chris fleizach 2014-06-05 11:00:27 PDT
Comment on attachment 232493 [details]
Patch to add support for the 'none' role in ARIA 1.1

looks good, just include a change log for layout tests and webcore, by running
./Tools/Scripts/prepare-ChangeLog --bug=133367

when you upload the new patch make sure you set review ?
Comment 4 Michael Timbrook 2014-06-05 11:53:17 PDT
Created attachment 232569 [details]
Updated patch with change log
Comment 5 Michael Timbrook 2014-06-05 11:54:09 PDT
Created attachment 232570 [details]
Updated patch with change log
Comment 6 Michael Timbrook 2014-06-05 11:55:28 PDT
Created attachment 232571 [details]
Updated patch with change log
Comment 7 Michael Timbrook 2014-06-05 15:58:42 PDT
Created attachment 232587 [details]
svn compatible patch

Made sure the patch would be accepted by svn
Comment 8 Michael Timbrook 2014-06-05 16:11:34 PDT
Created attachment 232590 [details]
adds aria 'none' role
Comment 9 Michael Timbrook 2014-06-05 16:28:30 PDT
Created attachment 232591 [details]
Added 'none' role
Comment 10 Michael Timbrook 2014-06-05 16:29:19 PDT
Created attachment 232592 [details]
added 'none' role
Comment 11 Michael Timbrook 2014-06-05 16:33:17 PDT
Created attachment 232593 [details]
added 'none' role
Comment 12 WebKit Commit Bot 2014-06-05 17:23:31 PDT
Comment on attachment 232593 [details]
added 'none' role

Clearing flags on attachment: 232593

Committed r169632: <http://trac.webkit.org/changeset/169632>
Comment 13 WebKit Commit Bot 2014-06-05 17:23:36 PDT
All reviewed patches have been landed.  Closing bug.
Comment 14 chris fleizach 2014-06-13 08:44:56 PDT
*** Bug 133856 has been marked as a duplicate of this bug. ***