Summary: | Perserve caption selection in fullscreen. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jeremy Jones <jeremyj-wk> | ||||||
Component: | Media | Assignee: | Jeremy Jones <jeremyj-wk> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | calvaris, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, philipj, sergio | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | iPhone / iPad | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Jeremy Jones
2014-05-28 11:00:58 PDT
Created attachment 232206 [details]
Patch
Comment on attachment 232206 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232206&action=review > Source/WebCore/ChangeLog:8 > + Use the logic from the line player to calculate the selected caption index. Nit: "from the line player" -> "from the inline player" > Source/WebCore/platform/ios/WebVideoFullscreenModelMediaElement.mm:297 > + if (trackList && m_mediaElement->document().page() && m_mediaElement->mediaControlsHost()) { This should be an early return. > Source/WebCore/platform/ios/WebVideoFullscreenModelMediaElement.mm:303 > + Vector<String> legibleOptions; Nit: I had to read through the code to figure out what "legibleOptions" meant, so something like "trackDisplayNames" might be better. > Source/WebCore/platform/ios/WebVideoFullscreenModelMediaElement.mm:326 > + if (offIndex && displayMode == MediaControlsHost::forcedOnlyKeyword() && !trackMenuItemSelected) { Nit: "!trackMenuItemSelected" is cheaper than "displayMode == MediaControlsHost::forcedOnlyKeyword()" so it should be first. Created attachment 232222 [details]
Patch
Comment on attachment 232222 [details] Patch Clearing flags on attachment: 232222 Committed r169450: <http://trac.webkit.org/changeset/169450> All reviewed patches have been landed. Closing bug. |