Bug 133350

Summary: Perserve caption selection in fullscreen.
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: MediaAssignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jeremy Jones
Reported 2014-05-28 11:00:58 PDT
Perserve caption selection in fullscreen.
Attachments
Patch (4.79 KB, patch)
2014-05-28 11:10 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Patch (4.47 KB, patch)
2014-05-28 17:04 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jeremy Jones
Comment 1 2014-05-28 11:01:53 PDT
radar://17046725
Jeremy Jones
Comment 2 2014-05-28 11:10:00 PDT
Created attachment 232206 [details] Patch
Eric Carlson
Comment 3 2014-05-28 11:22:58 PDT
Comment on attachment 232206 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232206&action=review > Source/WebCore/ChangeLog:8 > + Use the logic from the line player to calculate the selected caption index. Nit: "from the line player" -> "from the inline player" > Source/WebCore/platform/ios/WebVideoFullscreenModelMediaElement.mm:297 > + if (trackList && m_mediaElement->document().page() && m_mediaElement->mediaControlsHost()) { This should be an early return. > Source/WebCore/platform/ios/WebVideoFullscreenModelMediaElement.mm:303 > + Vector<String> legibleOptions; Nit: I had to read through the code to figure out what "legibleOptions" meant, so something like "trackDisplayNames" might be better. > Source/WebCore/platform/ios/WebVideoFullscreenModelMediaElement.mm:326 > + if (offIndex && displayMode == MediaControlsHost::forcedOnlyKeyword() && !trackMenuItemSelected) { Nit: "!trackMenuItemSelected" is cheaper than "displayMode == MediaControlsHost::forcedOnlyKeyword()" so it should be first.
Jeremy Jones
Comment 4 2014-05-28 17:04:32 PDT
Created attachment 232222 [details] Patch
WebKit Commit Bot
Comment 5 2014-05-29 09:41:58 PDT
Comment on attachment 232222 [details] Patch Clearing flags on attachment: 232222 Committed r169450: <http://trac.webkit.org/changeset/169450>
WebKit Commit Bot
Comment 6 2014-05-29 09:42:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.