| Summary: | Remove redundant GraphicsContext::drawImage() function. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | agomez, calvaris, cgarcia, cmarcelo, commit-queue, eric.carlson, esprehn+autocc, glenn, gustavo, gyuyoung.kim, jer.noble, kondapallykalyan, luiz, menard, mrobinson, noam, philipj, pnormand, sergio, simon.fraser, vjaquez | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 232201 [details]
Patch
Created attachment 232203 [details]
Patch
Created attachment 232277 [details]
Patch
A follow-up patch will consolidate the drawImage parameters to a struct. Comment on attachment 232277 [details]
Patch
ImageOrientationDescription() is so mysterious.
Comment on attachment 232277 [details] Patch Clearing flags on attachment: 232277 Committed r169484: <http://trac.webkit.org/changeset/169484> All reviewed patches have been landed. Closing bug. |
These 2 functions have very similar parameter list and by looking at WebCore code, people sometimes get confused which one to call. (and provide default values for parameters when they are not needed at all) void drawImage(Image*, ColorSpace styleColorSpace, const FloatRect& destRect, const FloatRect& srcRect, CompositeOperator = CompositeSourceOver, ImageOrientationDescription = ImageOrientationDescription(), bool useLowQualityScale = false); void drawImage(Image*, ColorSpace styleColorSpace, const FloatRect& destRect, const FloatRect& srcRect, CompositeOperator, BlendMode, ImageOrientationDescription = ImageOrientationDescription(), bool useLowQualityScale = false);