Bug 133347

Summary:

Remove redundant GraphicsContext::drawImage() function.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

agomez, calvaris, cgarcia, cmarcelo, commit-queue, eric.carlson, esprehn+autocc, glenn, gustavo, gyuyoung.kim, jer.noble, kondapallykalyan, luiz, menard, mrobinson, noam, philipj, pnormand, sergio, simon.fraser, vjaquez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

zalan

Reported 2014-05-28 09:01:43 PDT

These 2 functions have very similar parameter list and by looking at WebCore code, people sometimes get confused which one to call. (and provide default values for parameters when they are not needed at all) void drawImage(Image*, ColorSpace styleColorSpace, const FloatRect& destRect, const FloatRect& srcRect, CompositeOperator = CompositeSourceOver, ImageOrientationDescription = ImageOrientationDescription(), bool useLowQualityScale = false); void drawImage(Image*, ColorSpace styleColorSpace, const FloatRect& destRect, const FloatRect& srcRect, CompositeOperator, BlendMode, ImageOrientationDescription = ImageOrientationDescription(), bool useLowQualityScale = false);

Attachments
Patch (9.25 KB, patch) 2014-05-28 09:20 PDT, zalan	no flags	Details Formatted Diff Diff
Patch (10.79 KB, patch) 2014-05-28 09:31 PDT, zalan	no flags	Details Formatted Diff Diff
Patch (12.87 KB, patch) 2014-05-29 18:59 PDT, zalan	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.